<html>
<head><meta charset="utf-8"><title>codeowners · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html">codeowners</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="136555560"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136555560" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136555560">(Oct 26 2018 at 15:47)</a>:</h4>
<p>Has Rust ever tried to set up a <a href="https://help.github.com/articles/about-codeowners/" target="_blank" title="https://help.github.com/articles/about-codeowners/">CODEOWNERS</a> file?</p>



<a name="136555650"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136555650" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136555650">(Oct 26 2018 at 15:49)</a>:</h4>
<p>that sounds cool</p>



<a name="136559681"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136559681" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136559681">(Oct 26 2018 at 17:00)</a>:</h4>
<p>hmm, that would duplicate the information in highfive's configuration file</p>



<a name="136559720"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136559720" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136559720">(Oct 26 2018 at 17:00)</a>:</h4>
<p>which is the one actually used to make decisions about who gets assigned to the PR</p>



<a name="136559740"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136559740" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136559740">(Oct 26 2018 at 17:00)</a>:</h4>
<p>it would be interesting to migrate highfive to use it</p>



<a name="136560376"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136560376" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nagisa <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136560376">(Oct 26 2018 at 17:10)</a>:</h4>
<p>Unlike with LLVM, where parts of code are fairly independent, and are expected to be maintained by the person who initially contributed some feature (backend, optimisation etc)… I don’t think it applies very well to Rust</p>



<a name="136560422"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136560422" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nagisa <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136560422">(Oct 26 2018 at 17:11)</a>:</h4>
<p>I wouldn’t like to maintain such a file at all. Would rather a heuristic that uses e.g. blame from surrounding code (which is a similar heuristic to what we use today?)</p>



<a name="136560538"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136560538" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136560538">(Oct 26 2018 at 17:13)</a>:</h4>
<p>I think highfive just considers which team owns a directory</p>



<a name="136560624"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136560624" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136560624">(Oct 26 2018 at 17:14)</a>:</h4>
<p>this should be it <a href="https://github.com/rust-lang-nursery/highfive/blob/master/highfive/configs/rust.json" target="_blank" title="https://github.com/rust-lang-nursery/highfive/blob/master/highfive/configs/rust.json">https://github.com/rust-lang-nursery/highfive/blob/master/highfive/configs/rust.json</a></p>



<a name="136560667"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136560667" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136560667">(Oct 26 2018 at 17:15)</a>:</h4>
<p>I think CODEOWNERS supports setting teams as owners, so that could help us manage it</p>



<a name="136560728"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136560728" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136560728">(Oct 26 2018 at 17:16)</a>:</h4>
<p>maybe creating teams like <code>@rust-lang/rustc-review-borrowck</code> to assign to specific parts of the codebase</p>



<a name="136560754"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136560754" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136560754">(Oct 26 2018 at 17:16)</a>:</h4>
<p>There's already <code>@wg-compiler-nll</code> that could be used for some things.</p>



<a name="136560762"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136560762" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136560762">(Oct 26 2018 at 17:16)</a>:</h4>
<p>(for example)</p>



<a name="136561019"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136561019" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136561019">(Oct 26 2018 at 17:21)</a>:</h4>
<p>I don't think all the members of that WG have r+ rights though</p>



<a name="136562866"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136562866" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136562866">(Oct 26 2018 at 17:50)</a>:</h4>
<p>That’s true. But they might want to review anyway?</p>



<a name="136563437"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136563437" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136563437">(Oct 26 2018 at 17:59)</a>:</h4>
<p>I don't think it's useful to assign a PR to someone who can't approve it</p>



<a name="136563716"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136563716" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136563716">(Oct 26 2018 at 18:02)</a>:</h4>
<p>I'm not a big fan of having to modify the main rust repo for this</p>



<a name="136563730"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136563730" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136563730">(Oct 26 2018 at 18:03)</a>:</h4>
<p>though one thing I <strong>would</strong> like is some sort of bot to let people add themselves to the rust org so we can assign them to issues</p>



<a name="136563745"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136563745" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136563745">(Oct 26 2018 at 18:03)</a>:</h4>
<p>(extending highfive seems good tho)</p>



<a name="136564657"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136564657" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136564657">(Oct 26 2018 at 18:19)</a>:</h4>
<p>Zulip have a bot that lets people assign themselves. Not sure if it needs to add them to the org.</p>



<a name="136564714"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136564714" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136564714">(Oct 26 2018 at 18:20)</a>:</h4>
<p>GH doesn't permit you to be assigned to an issue unless you belong to the org</p>



<a name="136564719"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136564719" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136564719">(Oct 26 2018 at 18:20)</a>:</h4>
<p>I know some other teams at mozilla do this too</p>



<a name="136564731"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136564731" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136564731">(Oct 26 2018 at 18:20)</a>:</h4>
<blockquote>
<p>GH doesn't permit you to be assigned to an issue unless you belong to the org</p>
</blockquote>
<p>one of the things I find most annoying about GH, btw :)</p>



<a name="136564746"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136564746" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136564746">(Oct 26 2018 at 18:20)</a>:</h4>
<p>I assume their bot adds people to the org then.</p>



<a name="136564756"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136564756" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136564756">(Oct 26 2018 at 18:21)</a>:</h4>
<p>yeah, presumably</p>



<a name="136564873"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136564873" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136564873">(Oct 26 2018 at 18:23)</a>:</h4>
<p><a href="https://github.com/zulip/zulipbot/blob/master/.github/README.md" target="_blank" title="https://github.com/zulip/zulipbot/blob/master/.github/README.md">https://github.com/zulip/zulipbot/blob/master/.github/README.md</a></p>



<a name="136564949"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136564949" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136564949">(Oct 26 2018 at 18:24)</a>:</h4>
<p>ooh, yeah, we have needed some stuff like this forever</p>
<blockquote>
<p>t allows anyone to perform issue triage (self-assigning and labeling issues), not just the core contributors trusted with full write access to the repository (which is the only model GitHub supports).</p>
</blockquote>



<a name="136570637"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/codeowners/near/136570637" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> csmoe <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/codeowners.html#136570637">(Oct 26 2018 at 20:06)</a>:</h4>
<p>recalling from my previous trip with github-api, GH seems have a limitation on admin/member ninvitations per day.<br>
<a href="https://zulip.readthedocs.io/en/latest/contributing/zulipbot-usage.html" target="_blank" title="https://zulip.readthedocs.io/en/latest/contributing/zulipbot-usage.html">https://zulip.readthedocs.io/en/latest/contributing/zulipbot-usage.html</a><br>
zulipbot gives the assign/label permission by inviting a new contributor as a collaborator.</p>
<p>this reminds me of: could the team maintain a list of Gandalf in certain topic? as far as I know(maybe not), like diagnosis's estebank, rust-llvm's nagisa, etc. it'll be easier for newcomers to get helps. <br>
And while an issue is <code>@bot claim</code>ed, then the bot can guide the assigned collaborator to the right wg-team based on the label like: <br>
if any help needed, feel free to post for help in xx-team(<a href="https://team-chat-link" target="_blank" title="https://team-chat-link">https://team-chat-link</a>).</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>